Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds correct fractal root wallet for mandala #134

Merged
merged 7 commits into from May 9, 2022
Merged

Adds correct fractal root wallet for mandala #134

merged 7 commits into from May 9, 2022

Conversation

naps62
Copy link
Member

@naps62 naps62 commented May 5, 2022

Fixes #133

Took the chance to refactor a bit the deployConfigs file, by extracting some duplicates into aux functions

The core changes are two:

  • Adds a new network-specific parameters to deploy scripts: the root address that will control the fractal registry
  • For mandala deploys, an additional script is ran that adds deployer as a delegate as well, so we can handle testing from our side as well

@vercel
Copy link

vercel bot commented May 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discovery-dao ✅ Ready (Inspect) Visit Preview May 9, 2022 at 4:10PM (UTC)

@github-actions github-actions bot added the small small changes label May 5, 2022
@github-actions github-actions bot requested a review from zamith May 5, 2022 16:58
},
ctndSale2: {
start: now,
start: now + THIRTY_MIN,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need the two sales for mandala? Want to test all of that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is on hardhat, not mandala

@github-actions github-actions bot requested a review from zamith May 9, 2022 07:57
@naps62 naps62 merged commit 327e7c1 into main May 9, 2022
@naps62 naps62 deleted the add-delegate branch May 9, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small small changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

registry root address for Mandala
2 participants