Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation Issue with serial Feature #332

Closed
0xkanekiken opened this issue Feb 28, 2024 · 0 comments
Closed

Compilation Issue with serial Feature #332

0xkanekiken opened this issue Feb 28, 2024 · 0 comments

Comments

@0xkanekiken
Copy link
Contributor

0xkanekiken commented Feb 28, 2024

While working on #321, I encountered a verification error that I believe is due to an unsatisfied AIR constraint.

Here's a screenshot of the error:

Screenshot 2024-02-28 at 11 34 49 PM

I found a section in the codebase that allows for the evaluation of all AIR constraints. This functionality is not enabled by default and is only turned on when compiling the codebase without the perf flag and disabling the default features.

pub fn debug_constraints<SC: StarkGenericConfig>(
chip: &RiscvChip<SC>,
preprocessed: Option<&RowMajorMatrix<SC::Val>>,
main: &RowMajorMatrix<SC::Val>,
perm: &RowMajorMatrix<SC::Challenge>,
perm_challenges: &[SC::Challenge],
) where

Attempting to compile the code with the serial feature (and default features turned off) resulted in compilation failure. This issue arises because the serial flag disables the rayon features, yet the module in question relies on rayon by default.

// The permutation trace is actually the multiplicative inverse of the RLC's we computed above.
permutation_trace_values
.chunks_mut(chunk_rate)
.par_bridge()
.for_each(|chunk| batch_multiplicative_inverse_inplace(chunk));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants