Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't know what position from the ctrl+shift+p menu #40

Closed
luisrudge opened this issue May 21, 2015 · 5 comments · Fixed by #45
Closed

Can't know what position from the ctrl+shift+p menu #40

luisrudge opened this issue May 21, 2015 · 5 comments · Fixed by #45
Assignees
Labels

Comments

@luisrudge
Copy link

image

@jerone
Copy link
Contributor

jerone commented May 21, 2015

Confirmed.
It's because of the second : in the commands.
But I'm not sure if this is a ToolBar issue, as it is nowhere stated that multiple : aren't allowed in commands.

@jerone
Copy link
Contributor

jerone commented May 21, 2015

I submitted an issue on Atom repo atom/atom#6893, waiting to hear if they think it's a bug or that we need to change our commands...

@jerone
Copy link
Contributor

jerone commented May 21, 2015

So we need to change the commands to comply to Atom commands format namespace-name:event-name; atom/atom#6893 (comment)

I suggest we use:
tool-bar:position-top
tool-bar:position-right
tool-bar:position-bottom
tool-bar:position-left

Question arises; should be keep the old commands for legacy?

cc @suda

@suda
Copy link
Collaborator

suda commented May 24, 2015

@jerone I don't think changing those commands would break anything. We should change them to ones suggested by you.

@jerone jerone added the bug label May 24, 2015
@jerone jerone mentioned this issue May 25, 2015
@jerone jerone self-assigned this May 26, 2015
jerone added a commit that referenced this issue May 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants