Change tooltip position based on toolbar position

[kankaristo]

Thanks for a great package, makes Atom feel a lot more like an IDE. :)

However, the tooltips for the buttons appear on top of the buttons (I have my toolbar on the left side).

TooltipManager::add has an option to set the position (placement) of the tooltip.

The tooltip position should ideally be opposite of the toolbar position. So if the toolbar is at the top, the tooltip should be shown below; if the toolbar is on the left, the tooltip should be on the right.

This is what I did in tool-bar-button-view.coffee:

if options.tooltip
  @prop 'title', options.tooltip
  @subscriptions.add atom.tooltips.add(
    this,
    {
      title: options.tooltip
      delay:
        show: 0
        hide: 0
      placement: 'right'  # Opposite of the toolbar's position
    }
  )

(I also set the delay to 0, by personal preference).

Do you think this could be made the default behavior?

[jerone]

Hi @kankaristo, thanks for using this package.

I like your idea 💡 of placing the tooltips to the side when the tool-bar is vertical. On a horizontal tool-bar the tooltips are already placed correctly.

For the delay part, I prefer to keep this in sync with the tabs package or default value as with status-bar package.

Would you like to do a PR?

[kankaristo]

Pull request: #69

[kankaristo]

Fixed in b2a9e65