Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show over/under Tree View as well #91

Closed
pradyunsg opened this issue Sep 22, 2015 · 10 comments
Closed

Show over/under Tree View as well #91

pradyunsg opened this issue Sep 22, 2015 · 10 comments

Comments

@pradyunsg
Copy link

Currently, the Tool Bar is shown only over/under the editor-portion of the editor.

It would be nicer if it would be shown over and under the tree-view as well (File Browser/Sidebar/whatever).

PS: I was planning to use this as an alternative to the menu-bar but without something this, it's not really good-looking. 😅

@jerone
Copy link
Contributor

jerone commented Sep 22, 2015

It would be nicer if it would be shown over and under the tree-view as well

That's not possible due to Atom's way of available panels in the workspace. See https://discuss.atom.io/t/rearrange-status-bar-to-the-bottom-panel/18597/6

The linked topic does note a workaround that you can put in your styles.less to achieve the same effect.

@pradyunsg
Copy link
Author

Ah, so it's technically difficult. So, could you put the relevant code snippet in the README (for reference?)

PS: I did this but I'm having a hard time figuring out the height part... It probably needs the Tree-View moved vertically as well.

@jerone
Copy link
Contributor

jerone commented Sep 26, 2015

Tracking upstream: atom/atom#8939

@simurai
Copy link
Contributor

simurai commented Oct 3, 2015

FYI: I tried out putting the tool-bar full width at the bottom atom/atom#8939 (comment), but it felt weird. I think the status-bar should always be the last thing at the bottom and packages can be above it.

Also, having the tool-bar at the top with full-width would make it visually uneven. So I think keeping it like it is now is still the best option. Personally, I prefer the tool-bar on the sides.

@jerone
Copy link
Contributor

jerone commented Oct 3, 2015

Personally I have the tool-bar positioned at the top, like any other (Windows) desktop program has placed their (customizable) toolbars. To this day I find it weird that it's beside the tree-view and not above it, while it contains buttons that are related to the tree-view and not the editor only.
I still believe this should be implemented as another API function, so packages can position their bars/panels like they want. 👍

@jerone
Copy link
Contributor

jerone commented Feb 1, 2016

atom/atom#9274 was just merged, making it possible to attach to a panel that spans across the whole width and not just above/under the editor.

Waiting for another beta release before we can work on this.

@simurai
Copy link
Contributor

simurai commented Feb 1, 2016

Waiting for another beta release before we can work on this.

Something I was wondering (a bit off-topic).. how do you add something to beta but not stable? Do you release tool-bar with something like "atom": ">=1.5.0" here. Then only people with that version should see an update. And then once it lands in stable, go back to "atom": ">=0.188.0"? I guess the problem is that it would block any other updates to tool-bar that should go into stable?

@jerone
Copy link
Contributor

jerone commented Feb 2, 2016

how do you add something to beta but not stable?

I don't think this is possible yet, as it looks like the engine property is ignored at this time.

For now I just want to wait for beta to have the updated core packages required for this feature, before I (or someone else) is going to work on this.

jerone added a commit that referenced this issue Mar 18, 2016
✨ Full width header & footer tool bar. Closes #91
@pradyunsg
Copy link
Author

✨ Yay! 🎉

@varemenos
Copy link
Contributor

A Docks feature was added recently to the latest beta, I'm ynder the assumption that this feature could be implemented via the Docks API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants