🔥 Remove legacy spece-pen view api compat #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -35,7 +32,6 @@ | |||
| "tool-bar": { | |||
| "description": "A container for buttons at workspace edge", | |||
| "versions": { | |||
| "0.1.0": "provideToolBarLegacy", | |||
| "1.0.0": "provideToolBar" | |||
There was a problem hiding this comment.
We could merge 0.1.0 and 1.0.0 together...
There was a problem hiding this comment.
Supporting 0.1.0 means having to keep grim and jquery :(
There was a problem hiding this comment.
Not necessarily, in my research only 3 package used the extended API. Nuclide is up-to-date, Flex Tool Bar hopefully soon, and don't really care about Atom-macros.
There was a problem hiding this comment.
Maybe I'm misunderstanding what you meant by "merge". Are you saying:
"tool-bar": {
"versions": {
"0.1.0": "provideToolBar",
"1.0.0": "provideToolBar"
}
}
That's kinda dangerous, since you don't know what kinds of private packages people have
23 tasks
ghost
pushed a commit
to facebookarchive/nuclide
that referenced
this pull request
Sep 7, 2016
Summary: V0 of the tool-bar API is going away in atom-community/tool-bar#153. It's been almost 5 months since V1 was introduced, so lets finish the transition. Reviewed By: matthewwithanm Differential Revision: D3826349 fbshipit-source-id: a88cf7076352a0e62f33c717367c14063fe75396
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup