New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text/html button #217
Text/html button #217
Conversation
looks like travis failed because macos build got canceled. @suda can you restart the macos builds? |
@suda any feedback on this? |
@suda I was able to implement this in cakecatz/flex-toolbar#125 but I had to use |
Oh sorry for keep you waiting! Merging it now :) |
Does this close #197? |
@edjubuh yes, you can add svg elements with: toolbar.addbutton({
tooltip: 'Cherry Pick',
text: '<svg ...',
html: true,
callback: 'git-plus:cherry-pick'
}); |
Add text and html options
html is a boolean attribute to allow the text to be inserted as html
I also made the icon optional to allow for just text buttons
fixes #215
fixes cakecatz/flex-toolbar#111
fixes cakecatz/flex-toolbar#120