Add any class to a toolbar button

[ericcornelissen]

Closes #271, this would allow users to add any class(es) to buttons. They can then define the class in a local stylesheet an customize buttons as they see fit.

They can do this through the class option which can be either a string or an array of strings. If it is an array every string will be added separately.

Arguably this is unnecessary as you can add multiple strings simply by putting spaces in the string. This is not possible with the current implementation, but an be implemented instead if desired.

Example usage:

  toolBar.addButton({
    icon: 'octoface',
    callback: 'application:about',
    class: 'my-awesome-class'
  });

  toolBar.addButton({
    icon: 'octoface',
    callback: 'application:about',
    class: ['multiple', 'classes', 'also', 'works']
  });

[aminya]

This is awesome. Thanks for the work

[aminya]

It would more useful if you provide a full example that includes the class definition (something which is not possible using the simple options' syntax).

[ericcornelissen]

Good suggestion! I would like some feedback from @suda on how they would like to incorporate that into the documentation.

Some possible options:

• Add a new file for it docs/button-with-class.md (perhaps a bit overkill, though other options might benefit from a similar approach?)
• Add it to the repo wiki
• Create a gist with an example and link there

[aminya]

I think if the class definition is short it can be put at the end of the main readme. But if it takes a lot of space the separate markdown file is a better option. Gist works too, but markdown file stays in this repository.

I don't think repo Wiki is suitable for this case.

[ericcornelissen]

I think if the class definition is short it can be put at the end of the main readme. But if it takes a lot of space the separate markdown file is a better option.

I'm mainly just not sure where to put it... I have a comparable thing in the README for one of my own packages, but the use case is slightly different here...

Gist works too, but markdown file stays in this repository.

Wanted to add that disclaimer, but thought it was self-evident. Thanks for pointed it out explicitly though!

I don't think repo Wiki is suitable for this case.

Yea, I'm not sure about it either, but it's definitely a valid option 😄

In the end, again, it's up to @suda

[suda]

I think adding it to the readme is perfectly fine :) The Example section covers all possible options and we can probably add it there :)

[ericcornelissen]

I put something together, let me know what you think 😄 (and I rebased the PR)

[suda]

Thanks for the contribution Eric! I merged some other PRs so you might need to rebase your work