Type declarations for TypeScript #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you agree with the content of the docstrings and the declarations itself, I will make a pull request to |
|
@suda Could you review this? |
suda
approved these changes
Apr 8, 2020
|
Thanks Amin! |
|
PR is created: DefinitelyTyped/DefinitelyTyped#43727 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds types for tool-bar public API.
However, since this package is not an
npmpackage, we should either push this to @types/atomor make a separate
@types/tool-bar.I prefer the first option,
../indexis referring to that file.Either way, it is good to keep a copy of that file here.
See this in action here: https://github.com/aminya/juno-plus