Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler warnings #5

Open
4 tasks
sudara opened this issue Nov 8, 2023 · 2 comments
Open
4 tasks

Compiler warnings #5

sudara opened this issue Nov 8, 2023 · 2 comments

Comments

@sudara
Copy link
Owner

sudara commented Nov 8, 2023 •
edited

I know, I know....

TODO:

  • Main module MSVC happy
  • Main module clang happy
  • Tests happy
  • Fail tests on warnings
@sudara sudara mentioned this issue Nov 8, 2023
Closed
@sudara
Copy link
Owner Author

sudara commented Dec 25, 2023

ee269d3 removed pixel_helpers from single_channel blur, which removed a few.

Not quite sure what to do with the unreferenced function with internal linkage has been removed ones on MSVC — perhaps just needs a [[maybe_unused]]? Those are useful in tests.

@sudara sudara mentioned this issue Dec 26, 2023
Merged
@sudara
Copy link
Owner Author

sudara commented Jan 8, 2024 •
edited

Related PRs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sudara