Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement custom color picker (from PlugData) #54

Open
sudara opened this issue Aug 16, 2023 · 5 comments
Open

Implement custom color picker (from PlugData) #54

sudara opened this issue Aug 16, 2023 · 5 comments
Labels

Comments

@sudara
Copy link
Owner

sudara commented Aug 16, 2023

Timothy from PlugData has graciously offered we steal their custom color picker so we can move away from JUCE's default one.

https://github.com/plugdata-team/plugdata/blob/main/Source/Utility/ColourPicker.h

@sudara sudara changed the title Implement Color Picker (from PlugData) Implement custom color picker (from PlugData) Aug 16, 2023
@reFX-Mike
Copy link

We have a more fully featured one here:

https://github.com/reFX/ColourSelector

It's the same functionality as Photoshop. The means the color-space square changes according to the mode, etc.

We could work together to make it prettier. It's based on the JUCE one, but then added features:

image

@sudara
Copy link
Owner Author

sudara commented Aug 17, 2023

Hey nice work!

For the inspector I'd like to:

  • Be able to pass in a hex/rgba preference for output value. Many of us working in vector/web are often more used to working with r,g,b,a values instead of hex
  • Have an alpha slider
  • Hide the "picked color" (the selector is pointing to it and it's visible in context)
  • Hide all the HSB/RGB values and sliders

So basically, I'd like to end up with similar to the PlugData version here (though the toggle isn't necessary since there's a toggle in the inspector already).

@reFX-Mike
Copy link

Except for the output as RGB values instead of hex, this is all supported. It uses the usual "flags" in the constructor and you can turn everything on/off invidivually.

@sudara
Copy link
Owner Author

sudara commented Aug 17, 2023

Nice!

For the inspector, I've also been thinking that the color picker should enable when the selector pops open (like every other app's color selector) and allow for repeated picking...

@reFX-Mike
Copy link

100% agree

@sudara sudara added the UI label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants