Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cheat in the inspector bounding box when whole plugin editor is selected #61

Open
sudara opened this issue Aug 22, 2023 · 1 comment
Open
Labels
good first issue Good for newcomers UI

Comments

@sudara
Copy link
Owner

sudara commented Aug 22, 2023

Right now

  • it's not noticible
  • it produces artifact looking stuff in the corners

AudioPluginHost - 2023-08-22 51@2x

@sudara sudara added UI good first issue Good for newcomers labels Aug 22, 2023
@sudara
Copy link
Owner Author

sudara commented Mar 19, 2024

@dikadk This one drives me crazy and might be easy for you since I think you last touched most of the selection logic.

Basically, we need to display the full corners + hover/selection line when they butt up against the overlay's edges.

So if there's a line at 0,0 to 500,0 we actually need to "cheat" the selection bounds and put them inside the boundary (enough that the full corners are visible, so maybe the line would have a y position of 3. And that goes for every edge separately...

just not sure if we use the drawing bounds for calculations, like to show width/height and stuff, we want that stuff to stay exact, i guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers UI
Projects
None yet
Development

No branches or pull requests

1 participant