Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Efficient leave and join. #99

Closed
Anush008 opened this issue Jan 31, 2021 · 8 comments
Closed

Efficient leave and join. #99

Anush008 opened this issue Jan 31, 2021 · 8 comments

Comments

@Anush008
Copy link

Description:
The bot must know when to leave a VC and join another requested one, if there is a song playing in the former VC but no one's listening.

Steps to reproduce:

  1. Join a VC.
  2. Play a song
  3. Leave the VC
  4. Join another VC
    5)Ask for song.
    The bot will continue to play the song on the previous VC itself, but won't join the new one untill the song is over.

What should happen:
Let's consider Groovy, if someone plays a song in a VC and leaves the VC, joins another VC and asks for a song Groovy will quit the previous VC and join this one. But if someone is listening a song in a VC and someone else tries to connect it to another VC Groovy says 'Someone is already listening' as soon as the listener leaves the VC and lets Groovy alone, the 2nd person will be able to make Groovy join his VC.

This is exactly what should happen.

@Anush008
Copy link
Author

Anush008 commented Jan 31, 2021

If you didn't get what I mean, ping me, I'll elaborate.

@Colonel-Ltd
Copy link
Contributor

The bot will continue to play the song on the previous VC itself, ؟

@Anush008
Copy link
Author

Anush008 commented Feb 1, 2021

The bot will continue to play the song on the previous VC itself, ؟

That shouldn't happen, think about it. If someone leaves the bot alone playing a song, someone else who wants to listen to a song in another VC will have to wait till all the queued songs are over.

@Anush008
Copy link
Author

Anush008 commented Feb 3, 2021

@Colonel-Ltd

@kaaax0815
Copy link

+1

@booleans-oss
Copy link

Is anyone working on this suggestion ?

@sorae42
Copy link
Contributor

sorae42 commented Feb 12, 2021

For this scenario, I'd prevent user from choosing new song unless the bot is in the corresponding voice chat. (Bot should be in the same channel as user did, as it would do before.)

@SudhanPlayz
Copy link
Owner

Thanks for your suggestion, it has been added in TO-DO list of Discord Music Bot v4, which will be launched in a short period of time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants