Skip to content
This repository has been archived by the owner on Jan 14, 2024. It is now read-only.

Feature: Listen button #8

Open
OlegKunitsyn opened this issue May 2, 2021 · 3 comments
Open

Feature: Listen button #8

OlegKunitsyn opened this issue May 2, 2021 · 3 comments
Labels
easy enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@OlegKunitsyn
Copy link

For now all users that can join the audio stream are admins. I've extended userController by

    const role = users.length === 0 ? 'admin' : 'visitor'
    const user = {id,name,room,role};
...
    const role = usersInVoice.length === 0 ? 'admin' : 'visitor'
    const user = {id,name,room,role};

and replaced user:admin with user:user.role. In result, we have two roles of users.
Furthermore, visitors may get Listen button instead of admn's Join voice

@sudheer121
Copy link
Owner

Hey @OlegKunitsyn, you may open up a pull request, let me review it.
Having a mute button is a good idea, will work on it.

@sudheer121 sudheer121 added enhancement New feature or request good first issue Good for newcomers easy labels Aug 18, 2021
@sinahosseini76
Copy link

Hey @OlegKunitsyn I agree with you,
The Mute button is a good idea will all visitor can talk or not and handle echo sound of visitors with mute button!

@sinahosseini76
Copy link

Could you please add this mute button ? @OlegKunitsyn @sudheer121

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
easy enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants