Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments to improve the content #22

Closed
omerg opened this issue Jun 30, 2019 · 2 comments
Closed

Comments to improve the content #22

omerg opened this issue Jun 30, 2019 · 2 comments

Comments

@omerg
Copy link

omerg commented Jun 30, 2019

Hello @sudheerj , thank you for this wonderful collection of questions! Here are some of my comments to improve the document:

  • Duplicity: 82 and 109
    82 and 109 are almost the same and can be considered as duplicate ( 82: "Why we need to pass a function to setState()?" - 109: "Why function is preferred over object for setState?" )
  • Duplicity: 87 and 118
    87 and 118 refer to a very similar topic and can be merged ( 87: "Why should component names start with capital letter?" - 118: "Why React component names must begin with a capital letter?" )
  • 102: "How to listen to state changes?"
    componentWillUpdate is deprecated.
  • 182: "What are Redux selectors and why to use them?"
    I think why to use them is not mentioned. One specific need is when using them with "select" method of saga's.
  • 205: How to use TypeScript in create-react-app application?
    create-react-app now supports TypeScript natively: see: https://github.com/wmonk/create-react-app-typescript
  • 208: What is an action in Redux?
    Should go under redux section instead of misc.
  • 209: Does the statics object work with ES6 classes in React?
    There is a third way of writing statics; that is, outside the class:
class Component extends React.Component {
   ....
}

Component.propTypes = {...}
Component.someMethod = function(){....}

Hooks are a new feature proposal that lets you...

Hooks are no more a proposal

@sudheerj
Copy link
Owner

I will go through all of them. Thanks.

@sudheerj
Copy link
Owner

@omerg I covered all the above cases. Thanks for points. Anyway I will make more improvements in coming days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants