Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazelisk(-bin): Add both bazel and bazelisk to path #56

Open
uhthomas opened this issue Jan 31, 2022 · 3 comments
Open

bazelisk(-bin): Add both bazel and bazelisk to path #56

uhthomas opened this issue Jan 31, 2022 · 3 comments
Assignees
Labels
area/package-group/bazelisk Issue or PR that relates to all Bazelisk packages effort/minor This issue should be accomplishable very quickly kind/feature Categorizes issue or PR as related to a new feature triage/accepted Indicates an issue that has been accepted

Comments

@uhthomas
Copy link

The official Bazelisk installation suggests that both bazel and bazelisk should be in the path. It would be nice to keep the behaviour consistent.

@sudoforge
Copy link
Owner

sudoforge commented Jan 31, 2022

The Homebrew and NPM packages add both bazelisk and bazel, yes, but personally, I'd like to understand the use case a bit more before emulating that behavior. Could you explain what the different use cases are, if any, for having both bazel and bazelisk available in your PATH?


Also, I think it's important to differentiate between what the Homebrew and NPM packages do, and what is being suggested. Specifically, from the README:

Some ideas how to use it:

Install it as the bazel binary in your PATH (e.g. copy it to /usr/local/bin/bazel). Never worry about upgrading Bazel to the latest version again.

...

If you install Bazelisk as bazel on your CI machines, too, you can even ...

@sudoforge sudoforge added area: packages kind/feature Categorizes issue or PR as related to a new feature labels Feb 27, 2022
@mothran
Copy link

mothran commented Jan 13, 2023

I just encountered this issue and I would like just add that I have encountered build systems that explicitly call bazelisk. So having both targets would be more widely compatible, it also would match the official installer script, from the README:

Each adds bazelisk to the PATH as both bazelisk and bazel.

@sudoforge
Copy link
Owner

I have encountered build systems that explicitly call bazelisk

This is not the intended workflow, and those build systems are probably doing something wrong. They should simply call out to bazel.

Regardless, this is such a small change and is simple to implement; I'll concede that some people may benefit from having both a bazel and bazelisk call invoke the same executable (bazelisk), and add a symlink.

@sudoforge sudoforge reopened this Jan 15, 2023
@sudoforge sudoforge added area/package/bazelisk Issue or PR that relates to //bazelisk area/package/bazelisk-bin Issue or PR that relates to //bazelisk-bin area/package-group/bazelisk Issue or PR that relates to all Bazelisk packages effort/minor This issue should be accomplishable very quickly triage/accepted Indicates an issue that has been accepted and removed comp: bazelisk-bin area/package/bazelisk Issue or PR that relates to //bazelisk area/package/bazelisk-bin Issue or PR that relates to //bazelisk-bin labels Feb 19, 2023
@sudoforge sudoforge self-assigned this Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/package-group/bazelisk Issue or PR that relates to all Bazelisk packages effort/minor This issue should be accomplishable very quickly kind/feature Categorizes issue or PR as related to a new feature triage/accepted Indicates an issue that has been accepted
Projects
None yet
Development

No branches or pull requests

3 participants