Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to feed #10

Closed
3 tasks done
DirtyF opened this issue Jan 4, 2016 · 7 comments
Closed
3 tasks done

Fix link to feed #10

DirtyF opened this issue Jan 4, 2016 · 7 comments
Assignees
Labels

Comments

@DirtyF
Copy link
Contributor

DirtyF commented Jan 4, 2016

We have 404 on the blog feed :

Feed is generated with jekyll-feed, default config path is feed.xml
The url http://sudweb.fr/blog/feed.xml returns a 404 page.

  • We use Github Pages latest version
  • feed.xml is present in the _site folder
  • link tag is generated with default {% feed_path %}and returns {{ site.baseurl}}/feed.xml
@DirtyF DirtyF added the bug label Jan 4, 2016
@DirtyF DirtyF self-assigned this Jan 4, 2016
@DirtyF
Copy link
Contributor Author

DirtyF commented Jan 4, 2016

I updated the gems, the feed is well generated. Links are correct within the feed.xmlfile, but not in the link tag generated by {% feed_path % } who doesn't seem to handle {{ site.baseurl }}.

@thom4parisot
Copy link
Contributor

Weird indeed.

I have opened an issue on the plugin repo and replaced the tag by a manual link to the feed.

@DirtyF
Copy link
Contributor Author

DirtyF commented Jan 5, 2016

@oncletom Thanks, I wasn't sure it was an issue with the plugin, didn't take time to check in the source code if it was properly generated.

@thom4parisot
Copy link
Contributor

Nah me too, I am not sure it is a bug or not. We'll see.

@DirtyF
Copy link
Contributor Author

DirtyF commented Jan 5, 2016

I looked into the source code and asked the authors : jekyll/jekyll-feed#79 (comment)

@thom4parisot
Copy link
Contributor

@DirtyF that's probably better to report these details to the relevant issue: jekyll/jekyll-feed#79 ;-)

@DirtyF
Copy link
Contributor Author

DirtyF commented Jan 5, 2016

@oncletom you're right, done.

@DirtyF DirtyF closed this as completed in #11 Jan 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants