Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📎 Reduce the flickering in dark mode #33

Closed
Tracked by #12
sugar-cat7 opened this issue Aug 16, 2023 · 2 comments · Fixed by #168
Closed
Tracked by #12

📎 Reduce the flickering in dark mode #33

sugar-cat7 opened this issue Aug 16, 2023 · 2 comments · Fixed by #168
Assignees
Labels
enhancement New feature or request

Comments

@sugar-cat7
Copy link
Owner

No description provided.

@sugar-cat7 sugar-cat7 mentioned this issue Aug 16, 2023
7 tasks
@sugar-cat7 sugar-cat7 changed the title ダークモードのチラつきを抑えたい Reduce the flickering in dark mode Jan 1, 2024
@sugar-cat7 sugar-cat7 added the enhancement New feature or request label Jan 22, 2024
@sugar-cat7 sugar-cat7 changed the title Reduce the flickering in dark mode 📎 Reduce the flickering in dark mode Jan 28, 2024
@sruenwg
Copy link
Collaborator

sruenwg commented Jan 28, 2024

If this issue is referring to the behaviour seen in this clip:

spodule-dark-mode-ssr-flicker-1.mov

then I believe the problem is that the SSRed page always contains light mode styles, with dark mode styles only being applied once JS is run on the client.

MUI seems to solve this by making use of CSS variables.
Although the feature is marked as experimental, it might be worth trying out since it looks fairly well documented with a how-to guide for fixing our very problem.

@sugar-cat7
Copy link
Owner Author

Sounds good. Let's try CSS theme variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants