Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fully-qualified names for all tables and procedures in Debezium connector for SQL Server #10

Closed
morozov opened this issue Feb 25, 2021 · 0 comments · Fixed by #23
Closed
Assignees
Labels
SQL Server Debezium connector for SQL Server

Comments

@morozov
Copy link

morozov commented Feb 25, 2021

Acceptance criteria
  1. Each table name or stored procedure in each SQL query or statement executed by the connector is referenced by its fully qualified name including the database name.
  2. The ;databaseName=${" + JdbcConfiguration.DATABASE + "}" fragment of the JDBC configuration is removed from the SqlServerConnection URL pattern since it’s no longer needed.
  3. The project compiles, all tests pass.
Example workflow
  1. Identify all SQL fragments in the plugin codebase (e.g. the occurrences of "SELECT)
  2. Add a database placeholder to each table or procedure reference in each fragment, e.g.: SELECT sys.fn_cdc_get_max_lsn()SELECT [#].sys.fn_cdc_get_max_lsn().
  3. In the code that uses the fragment, implement the replacement of the placeholder with the database name. If the actual value is unavailable in the current scope, add a new method argument databaseName. Pass the database name from the connector configuration down the line where necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SQL Server Debezium connector for SQL Server
Projects
None yet
2 participants