Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeErrors when DEBUG_TERMINAL = True #13

Open
Dimi20cen opened this issue Sep 6, 2023 · 4 comments · May be fixed by #14
Open

TypeErrors when DEBUG_TERMINAL = True #13

Dimi20cen opened this issue Sep 6, 2023 · 4 comments · May be fixed by #14

Comments

@Dimi20cen
Copy link
Contributor

Dimi20cen commented Sep 6, 2023 •
edited
Loading

When I run the activity with DEBUG_TERMINAL = True in the activity.py, I get the following two tracebacks

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/gi/_propertyhelper.py", line 401, in obj_set_property
    prop.fset(self, value)
  File "/usr/local/lib/python3.10/dist-packages/sugar3/graphics/toolbarbox.py", line 188, in set_padding
    self._toolbar_alignment.set_padding(0, 0, pad, pad)
TypeError: Must be number, not VteActivity

Traceback (most recent call last):
  File "/usr/local/bin/sugar-activity3", line 5, in <module>
    activityinstance.main()
  File "/usr/local/lib/python3.10/dist-packages/sugar3/activity/activityinstance.py", line 231, in main
    instance = create_activity_instance(activity_constructor, activity_handle)
  File "/usr/local/lib/python3.10/dist-packages/sugar3/activity/activityinstance.py", line 59, in create_activity_instance
    activity = constructor(handle)
  File "/home/dim/Documents/GitHub/Lemonade/activity.py", line 53, in __init__
    self._vte.set_colors(Gdk.color_parse('#E7E7E7'),
TypeError: argument foreground: Expected Gdk.RGBA, but got gi.overrides.Gdk.Color
@Dimi20cen Dimi20cen changed the title Tracebacks when DEBUG_TERMINAL = True TypeErrors when DEBUG_TERMINAL = True Sep 6, 2023
Dimi20cen added a commit to Dimi20cen/Lemonade that referenced this issue Sep 6, 2023
@Dimi20cen
TypeErrors when DEBUG_TERMINAL = True
576f627 
Fixes sugarlabs#13
- Remove self from ToolBarBox()
- Use Gdk.RGBA instead of  Gtk.Color
@Dimi20cen Dimi20cen linked a pull request Sep 6, 2023 that will close this issue
Open
@chimosky
Copy link
Member

For future references, don't include GH issue numbers in your commit message as git doesn't understand that.

@Dimi20cen
Copy link
Contributor Author

I'm sorry I don't understand what you mean. Is there a problem with how this issue is created, or is it about a commit message I've made?

@quozl
Copy link

quozl commented Sep 21, 2023

The commit message. By referencing an issue inside a commit message, which GitHub loves because it uses their services, you create a dependency on GitHub for when the commit message is re-read in future by someone trying to find and fix a fault, or using git bisect. Explain the problem instead. We keep the git repository, we don't keep the GitHub issues or pull requests.

@Dimi20cen
Copy link
Contributor Author

Ahhh yeah, that was an oversight. Github desktop might have suggested it and I accidentally pressed on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TypeErrors when DEBUG_TERMINAL = True Dimi20cen/Lemonade
3 participants
@quozl @chimosky @Dimi20cen