Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to Python 3 #11

Closed
5 tasks done
quozl opened this issue Feb 20, 2019 · 9 comments
Closed
5 tasks done

Port to Python 3 #11

quozl opened this issue Feb 20, 2019 · 9 comments

Comments

@quozl
Copy link

quozl commented Feb 20, 2019 •
edited
Loading

@quozl quozl added this to Critical Issues in Port to Python 3 via Six Feb 20, 2019
@Aniket21mathur

This comment has been minimized.

Sign in to view
@Aniket21mathur

This comment has been minimized.

Sign in to view
@quozl

This comment has been minimized.

Sign in to view
@Aniket21mathur
Copy link

Any need to keep this issue open?

@quozl
Copy link
Author

quozl commented Jul 9, 2019

Someone forgot a "Fixes".

@quozl quozl closed this as completed Jul 9, 2019
@Aniket21mathur
Copy link

I did included it in 6169fd4, please see.

The issue was still open, strange!

@quozl
Copy link
Author

quozl commented Jul 9, 2019

The commits were squashed.

@quozl
Copy link
Author

quozl commented Jul 9, 2019

i.e. the pull request didn't have a fixes, one of the commits in the change set did, but that commit description was not kept when I merged.

@Aniket21mathur
Copy link

Ohh! Thanks for explaining. :-)
I will include "Fixes" in a comment on the pr from next time.

@Aniket21mathur Aniket21mathur removed this from Critical Issues in Port to Python 3 via Six Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@quozl @Aniket21mathur