Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add edit toolbar and buttons #18

Closed
quozl opened this issue Apr 26, 2018 · 4 comments
Closed

Add edit toolbar and buttons #18

quozl opened this issue Apr 26, 2018 · 4 comments

Comments

@quozl
Copy link
Contributor

quozl commented Apr 26, 2018

As of 7bb29e4 the result can be copied by selecting it and using a mouse drag or ctrl+c shortcut. A text clipping can be dragged from the frame into the input field. But there's no toolbar buttons.

Add an edit toolbar and buttons. See toolkit and other activities for an example edit toolbar and icons.

@Aniket21mathur
Copy link
Contributor

Can you please provide me more details about what kind of toolbar you want and which buttons should be there.It would be of great help to me if you give example of an activity.
Thanks a lot!

@quozl
Copy link
Contributor Author

quozl commented Jan 11, 2019

No, I'd prefer there be design input before I give my opinions. I'm not looking for slaves. 😀 Please review each of the activities in our core set, we call them Fructose, and look particularly at the edit toolbars and buttons associated with text editing.

@Hrishi1999
Copy link

I've implemented it but had a few doubts before I push my changes. Do we need a paste button? Should the paste button set the text of entry to converted value (this would change the meaning of the paste button)? Should the copy button copy the whole output or just the converted value?

@quozl
Copy link
Contributor Author

quozl commented Mar 7, 2019

Good point about paste. Copy alone would not be as useful. I withdraw the suggestion.

@quozl quozl closed this as completed Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants