Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to Python 3 #2

Closed
quozl opened this issue Feb 26, 2018 · 4 comments · Fixed by #3
Closed

Port to Python 3 #2

quozl opened this issue Feb 26, 2018 · 4 comments · Fixed by #3

Comments

@quozl
Copy link

quozl commented Feb 26, 2018

Port the activity to Python 3 and the Sugar Toolkit for GTK+ 3.

Requires some of sugarlabs/sugar-toolkit-gtk3#382 to be completed.

@quozl quozl changed the title Port to Six Port to Python 3 Feb 26, 2018
@rhl-bthr rhl-bthr mentioned this issue Jul 7, 2018
@rhl-bthr rhl-bthr removed this from To Do in Port to Python 3 via Six Jul 24, 2018
@Aniket21mathur
Copy link

@quozl any need to keep this issue open?

@quozl
Copy link
Author

quozl commented Mar 25, 2019

Thanks for asking. Happy to explain. Best reason is that #3 is not yet merged.

Why is it not yet merged? There's more to our ecosystem than GitHub. While we have released v0.113 of the toolkit, with Python 3 support, it has not been packaged by Ubuntu or Fedora yet, so there's no rush to merge Python 3 ports of activities since there is no place that they can be used, and if they are released accidentally the systems running v0.112 of the toolkit will fail to run them. This quandry is possibly called a "flag day change". I'm trying to control for that, see sugarlabs/sugar-docs@af47a5a for a recent example.

On the other hand, Hello World is not a core activity; it actually does nothing but serve as an example.

This isn't really the right place to discuss this, because so few people are watching this repository, but here's my current plan; either;

  • keep the pull requests open until both Fedora and Ubuntu have packaged v0.113 for Python 2 and Python 3,
  • merge the pull requests into a python3 branch, or;
  • create a python2 branch for ongoing maintenance and merge the pull requests into master branch.

A better place to discuss would be the sugar-devel@ mailing list.

@quozl quozl added this to Critical Issues in Port to Python 3 via Six Mar 25, 2019
@Aniket21mathur
Copy link

Aniket21mathur commented Mar 25, 2019

@quozl . I agree with you, we can merge into master after v0.113 gets packaged by Ubuntu or Fedora. It would be better to merge it into python3 branch now. Just going through the work done till now in the port to python 3 project for GSoC '19 proposal. Thanks for answering 😅 .

@quozl
Copy link
Author

quozl commented Mar 25, 2019

It is in python3 branch now, thanks.

@Aniket21mathur Aniket21mathur removed this from Critical Issues in Port to Python 3 via Six Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants