Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

two locos occupied the same coordinates #16

Closed
Saumya-Mishra9129 opened this issue Apr 14, 2020 · 1 comment
Closed

two locos occupied the same coordinates #16

Saumya-Mishra9129 opened this issue Apr 14, 2020 · 1 comment

Comments

@Saumya-Mishra9129
Copy link
Member

During press of lowercase keys as well as upperkeys, two locos occupied the same coordinates, so it was difficult to read the letters.
Steps involve - starting game from level 1 , reach to level -4, press lower keys - you may not see error in one try, try from start again in that case. Follow same steps for level-5.
For reference look at pr #14

@quozl
Copy link
Contributor

quozl commented Apr 15, 2020

Thanks. We use issues as a signal that we don't plan to fix something, so I've looked into this issue more deeply.

  • as originally written, the random positioning in new_game and _quad_to_xy does risk collision without detection,
  • for the initial games this is easy handled by the child,
  • for the letter games the solution is not obvious,
  • 2ca1280 added a feature to let the child drag to remove overlaps,
  • How to use LocoSugar does not mention this feature,
  • 1f9c2ac help with overlaps, by hiding the Loco after it is identified by the child.

So it would seem this is adequate, and my review comments in the pull request stem from ignorance of the activity features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants