Fix annotation for xdg_mime_list_parents (SL #4530) #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per SL #4530, there is a fatal crash in Sugar when retrieving mimetypes for some Journal entries when contructing the icon palette (for both the Journal list view and detail view). We isolated the problem to xdgmime.c, the call to xdg_get_mime_parents. Dnarvaez observed that the annotation for the return argument was missing and that the annotation for the return for mime_list_parents was wrong. This patch fixes these annotations.
|
Just tested (compared) it and it works! |
|
I guess this unintentional, but better avoid creating feature branches on the official repo. |
|
I deleted the branch. Also I modified the commit log to not exceed 80 lines and to say "Fixes #4530" which triggers the trac hook and closes the ticket automatically |
|
Yes. I pushed to the wrong repo. -walter On Thu, Aug 15, 2013 at 5:54 PM, Daniel Narvaez notifications@github.comwrote:
Walter Bender |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per SL #4530, there is a fatal crash in Sugar when retrieving mimetypes for some Journal entries when contructing the icon palette (for both the Journal list view and detail view). We isolated the problem to xdgmime.c, the call to xdg_get_mime_parents. Dnarvaez observed that the annotation for the return argument was missing and that the annotation for the return for mime_list_parents was wrong. This patch fixes these annotations.