Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttributeError: 'NoneType' object has no attribute 'add_window' #864

Closed
quozl opened this issue Aug 19, 2019 · 4 comments
Closed

AttributeError: 'NoneType' object has no attribute 'add_window' #864

quozl opened this issue Aug 19, 2019 · 4 comments

Comments

@quozl
Copy link
Contributor

quozl commented Aug 19, 2019

Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/jarabe/model/shell.py", line 624, in _window_opened_cb
    home_activity.add_window(window, is_main_window(window,
AttributeError: 'NoneType' object has no attribute 'add_window'

Reported by @bhulsken.

@quozl quozl added this to Critical Issues in Port to Python 3 via Six Aug 20, 2019
@iamprayush
Copy link

I'd like to work on solving this issue. I'm new here so could you please guide me on how to begin. Thanks in advance.

@quozl
Copy link
Contributor Author

quozl commented Sep 8, 2019

Thanks for offering.

To explain how to fix the issue I've looked at the traceback message, the source code near line 624, the entire function, the entire log reported, and then considered the message in relation to the previous messages in the same log.

The traceback was a consequence of the Journal failing to start. In turn the Journal failed because the Datastore failed. The Datastore failed because the Journal sent a limit as a floating-point value instead of an integer. In turn this was use of / instead of // after porting to Python 3.

Since the traceback happened, we have fixed the cause and made a new release.

So the only remaining thing to do is to close this issue with an explanation. Thanks for getting me to look at it! 😁

@quozl quozl closed this as completed Sep 8, 2019
@iamprayush

This comment has been minimized.

@quozl

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants