Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port from GConf #23

Merged
merged 3 commits into from
Mar 30, 2018
Merged

Port from GConf #23

merged 3 commits into from
Mar 30, 2018

Conversation

quozl
Copy link
Collaborator

@quozl quozl commented Mar 27, 2018

GConf is part of GTK+ 2 and will not be available. Write used GConf to get font face, font size, speech rate and pitch. These will now default. Speech feature is disabled due to 1a91524.

GConf is part of GTK+ 2 and will not be available.  Write used GConf to
get font face and size from defaults set by an integrator.  There is no
user interface in Write or Sugar for setting these values.

Remove font face and size defaults.
GConf is part of GTK+ 2 and will not be available.  Write used GConf to
get the speech rate and pitch set by Sugar Frame.

Remove the rate and pitch, and use defaults only.

Due to an AbiWord bug workaround in
1a91524, and that the AbiWord major and
minor version have not changed since, speech in Write is not enabled
anyway.
@rhl-bthr
Copy link
Contributor

Thank you.

Reviewed and tested.

@rhl-bthr rhl-bthr merged commit dcc1926 into sugarlabs:master Mar 30, 2018
@quozl
Copy link
Collaborator Author

quozl commented Mar 31, 2018

@Pro-Panda, thanks for merging. For future merges, it makes repository history cleaner to select rebase merging instead of merge commits. I've removed the merge commit by rebasing and force pushing. In general, merge commits are most useful when we have convergent simultaneous development by more than two developers; not a problem at the moment for Write.

@quozl quozl deleted the 2018-03-26-no-gconf branch March 31, 2018 02:07
@rhl-bthr
Copy link
Contributor

Thank you,
Noted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants