Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscribe button suggestion #181

Closed
satyamchaudharydev opened this issue Dec 10, 2017 · 5 comments
Closed

Subscribe button suggestion #181

satyamchaudharydev opened this issue Dec 10, 2017 · 5 comments

Comments

@satyamchaudharydev
Copy link

This is how the website looks now:
ezgif com-video-to-gif 3
Color change on hover is too drastic also the width of the input and subscribe button are not same, which doesn't seem right.

Ideally, it should be like that in my opinion.
ezgif com-video-to-gif 1
@lalitmee
Copy link

@satyamchaudharydev Anyone is working on this issue or not?

@satyamchaudharydev
Copy link
Author

I am working on this issue.

@VatsalBatra
Copy link

@satyamchaudharydev anyone working on this issue ,if not i wish to take it

@quozl
Copy link
Contributor

quozl commented Mar 26, 2018

These comments unrelated to the problem are a distraction. Please, don't use issues as a place to negotiate who will work on something. You may get no response. You may forget to say you've stopped working on it.

Please use a pull request instead. Check for pull requests linked to the issue; if there are none, then assume nobody has done anything. Begin to fix the problem, test, make your commits, push your commits, then make a pull request. Mention the issue number in the pull request, but not the commit message.

These practices allow the competition of ideas (via pull requests) instead of competition of observing capability or perceived suitability of a contributor (via issues).

Sugar Labs is a meritocracy.

This was referenced Mar 26, 2018
Closed
Merged
@ericyoondotcom ericyoondotcom mentioned this issue Oct 25, 2018
Closed
nathan-jacob added a commit to nathan-jacob/www-sugarlabs that referenced this issue Oct 25, 2018
@nathan-jacob
Fixes Issue sugarlabs#181
1265822 
This fix works in accordance with the fix in airspace.css
nathan-jacob added a commit to nathan-jacob/www-sugarlabs that referenced this issue Oct 25, 2018
@nathan-jacob
FIxes sugarlabs#181
f5f4478 
Works in accordance with fix in footer.html
nathan-jacob added a commit to nathan-jacob/www-sugarlabs that referenced this issue Oct 25, 2018
@nathan-jacob
Merge pull request #1 from nathan-jacob/patch-5
97998f9 
Fixes Issue sugarlabs#181
nathan-jacob added a commit to nathan-jacob/www-sugarlabs that referenced this issue Oct 25, 2018
@nathan-jacob
Fixes sugarlabs#181
50e9dfd 
in accordance with fix to footer.html
nathan-jacob added a commit to nathan-jacob/www-sugarlabs that referenced this issue Oct 25, 2018
@nathan-jacob
Merge pull request #2 from nathan-jacob/patch-7
e3c89f9 
Fixes sugarlabs#181
@nathan-jacob nathan-jacob mentioned this issue Oct 25, 2018
Merged
@quozl
Copy link
Contributor

quozl commented Oct 25, 2018

In #243, @yummypasta suggested removing the gap between the entry and the button.

My opinion is that it looks better with the gap; so that the function of each area can be clearly seen.

@quozl quozl closed this as completed in 881a9b4 Oct 29, 2018
ayushnagar123 added a commit to ayushnagar123/www-sugarlabs that referenced this issue Nov 25, 2018
@ayushnagar123
merge changes (#1)
74c8a4e 
* icon/link space

* Fixed text disappearing in mobile version navbar

* Fix attribution

Following a discussion on
sugarlabs#192 (comment)
the consensus seemed to be to change this wording.

* Centered pagination for carousel

the buttons for the middle portion (owl carousel under "A GLIMPSE OF SUGAR..." on index.html were left aligned, so this commit changes that to be centered.

* Remove minified airspace.css

Site is 4.96 MB over 79 requests, and the minified airspace.css saves
only a few network packets among thousands.  The minified file hinders
review of pull requests.  Remove it and fix references to it.

* Remove minified main.js and plugins.js

No need for them to be minified.

* Resequence lists

* Newsletter subscribe button - change spacing and width

Fixes sugarlabs#181

* changed profiles.md to profiles.html

Changed the look and feel of profile.md file using the html tag and changed the file type to .html. The format is as per the task assinged - (3 users per row in a table with cell spacing and padding.

* Add second Google verification file

To give samson goddy access to Google knownledge graph

* Update airspace.css

* Update nav.html

* Update airspace.css

* Update nav.html

* Update airspace.css

* Update nav.html

* Update airspace.css

* Update airspace.css

* Update nav.html

* Update airspace.css

* Update airspace.css

* Update nav.html

* Update airspace.css

* Revert "Webpage Styling for Google-Code in"

* Remove Sugar Labs Embedded Youtube Video

* Remove unused syntax.css

* Remove HTML5shiv from updated modernizr

* Replace redundant Social Share Kit with Ion Icons

* Remove unused .sass files

* Remove duplication between README.md and documentation.md (sugarlabs#247)

* Remove Chat

- it doesn't work at the moment, leading people astray,

- it isn't clear how to make it work.

Work in progress; there may be other things to remove or change.

* Update index.html

* Update index.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Match button and email width, make button consistent with Bootstrap
4 participants
@quozl @lalitmee @VatsalBatra @satyamchaudharydev