Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document how generate all files present in npm dist tarball #111

Closed
pravi opened this issue Feb 21, 2024 · 2 comments
Closed

document how generate all files present in npm dist tarball #111

pravi opened this issue Feb 21, 2024 · 2 comments

Comments

@pravi
Copy link

pravi commented Feb 21, 2024

package.json only mentions these as files,

"files": [
"LICENSE",
"index.js",
"lib/async.js",
"lib/async.min.js",
"dist/async.js",
"dist/async.min.js"
],

but npm dist tarballs has many files, there is no documentation on how to generate those other files and in debian, we need to build from source.

Is this generated using lodash-cli like https://salsa.debian.org/js-team/node-lodash/-/blob/master/debian/rules?ref_type=heads#L14 ?

more https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1064411

@pravi
Copy link
Author

pravi commented Feb 21, 2024

We did run the gulp task to generate it https://salsa.debian.org/js-team/node-neo-async/-/blob/master/debian/nodejs/build?ref_type=heads#L2 but since package.json#files don't mention it, this was not included in the package. It'd be nice if package.json#files can include it, but now this is enough for the debian package. Thanks to Akshay S Dinesh you figured this out.

@suguru03
Copy link
Owner

I will close the issue since it seems to be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants