Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

[Add to demands] button: String concat instead of sum #8

Closed
suhrmann opened this issue Apr 21, 2019 · 3 comments
Closed

[Add to demands] button: String concat instead of sum #8

suhrmann opened this issue Apr 21, 2019 · 3 comments
Assignees
@tbfuerst
Labels
bug Something is obviously not working

Comments

@suhrmann
Copy link
Owner

suhrmann commented Apr 21, 2019 •
edited

Using the button multiple times, the value of population is calculated using string concatenation instead of summing up the values.

E.g.:

  1. 1x Production Chain: Wood (15 Farmers)
  2. [Add to demands]
  3. Demands Calculation: 15 Farmers
  4. Doing 1 & 2 again results in 1515 Farmers

#javascriptisfun #typesafetysucks
@suhrmann suhrmann added the invalid This doesn't seem right label Apr 21, 2019
@tbfuerst
Copy link
Collaborator

gladly, there is such a thing as type casting :)
resolved in commit 293ecd4

suhrmann added a commit that referenced this issue Apr 24, 2019
@suhrmann
Replaced table with DataTable
622ccc2 
 + fixed issue #8
 + code enhancements
@tbfuerst
Copy link
Collaborator

Variable type conversion remains to be an issue in certain cases

#javascriptisfun

@tbfuerst tbfuerst reopened this Apr 24, 2019
@tbfuerst
Copy link
Collaborator

should be fixed now fad8b96

@suhrmann suhrmann added bug Something is obviously not working and removed invalid This doesn't seem right labels Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tbfuerst tbfuerst

Labels
bug Something is obviously not working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@suhrmann @tbfuerst