Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guide View Controllers Objective-C -> Swift Conversion #13

Open
5 of 6 tasks
NinjaSnail42 opened this issue Mar 8, 2020 · 10 comments
Open
5 of 6 tasks

Guide View Controllers Objective-C -> Swift Conversion #13

NinjaSnail42 opened this issue Mar 8, 2020 · 10 comments

Comments

@NinjaSnail42
Copy link
Contributor

NinjaSnail42 commented Mar 8, 2020

Convert the Guide View Controllers to Swift.

  • GuideCopingViewController

  • GuideSuicidePreventionViewController

  • GuideSafetyPlanViewController

  • GuideResourcesViewController

  • GuideOverviewViewController

  • GuideRecoveringViewController

@shayneptorres
Copy link
Contributor

@NinjaSnail42 Just noticed that you had EditWarningSignsViewController on your list of views to update. I had already started updating this since it was part of the SafetyPlan view controllers. Were you still planning on working on it?

@NinjaSnail42
Copy link
Contributor Author

Yeah sorry, I was listing off the Objective-C files that were in the "Guide" group, but it looks like the .m file is in the "Guide" group, and the header file is in the "Safety Plan" group. You can continue to update it I have not started working on it.

@NinjaSnail42
Copy link
Contributor Author

I just wanted to mention that I was still working on this. With everything that has been going on, I have suddenly had a lot more to do, and I have some issues now with Xcode not wanting to show the Swift file in the Assistant editor after I tried to merge....

@eddielement
Copy link
Contributor

That's so odd! Thanks for the update though :)

@danispringer
Copy link

Can I try working on this? Is it still wanted/not done yet?

@eddielement
Copy link
Contributor

@danispringer Go ahead! I will keep updating the app :)

@danispringer
Copy link

@eddielement I just opened the project and it has several warnings. I can fix those, if you would like to merge that (and can all those fixes be in a single branch or would you need them separated)?

Attaching:

Screenshot of xcode issues list

@danispringer
Copy link

@eddielement also: might I ask what RealmSwift is for, and whether it's necessary? If it's the only pod, and can be done without, we might be able to get rid of pods altogether in the project 🍾

@eddielement
Copy link
Contributor

@danispringer All one branch would be great! RealmSwift is the database that is used to store the safety plan, but we could consider shifting it over to Swift Package Manager. :) https://realm.io/realm-swift/

@danispringer
Copy link

@eddielement new spm branch much better, just note that the Xcode console printed something about a new version of Realm being available, even while running the app via the spm branch.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants