-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/native dark mode support #16
Feature/native dark mode support #16
Conversation
Had to convert GuideCopingViewController to Swift and update the color of the text programatically in the Coping ViewController.
• Converted some files to Swift to update text color programatically for attributed text. • Changed the color of the table rows so that they are now white/dark grey instead of light grey/dark grey.
…ttom when opening a page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small changes that I would recommend. These aren't breaking anything but would be good to keep app consistent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just make sure you fix the merge conflicts. I also agree we should add a .gitignore
I just checked over it now and it looks great to me too just with a few merge conflicts to fix. Agreed on the gitignore (although I've tried and failed in the past at ignoring that- maybe there are lots of different DS_Stores?). Thanks for your input too @shayneptorres ! |
Yeah, apologies for the merge conflict on the storyboard file. I was a dev manager on an iOS project last year for a class at University, and it is quite a pain to fix merge conflicts in the storyboard files. |
I fixed the merge conflicts. Had to change repositories from my fork to the actual repo. Should be good for an admin to merge now. |
Match the Crisis page match the Guide page
Whew thank you for that @NinjaSnail42 !! I tried to resolve the conflicts for 30 minutes earlier, it was quite hellish, and I ended up discarding all my changes and was going to try again tonight. I made a few tweaks and I'm merging the changes in now! :) |
#4 Native Dark Mode support for the app.
Notes
Testing