Issue-22 Add Share plan button on the Plan page #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22
The added sharing icon is from SF Symbols app. For this reason, there is no need to add an author info.
I've removed the ic_action_share icon, as it doesn't seem to be used in the project. If in doubt, I can return.
Testing
Checks
Important
I couldn't check the plan with the first five items filled in, because new Xcode 13.2.1 / 13.4.1 builds with some UI bugs:
The video with 1 and 2: https://user-images.githubusercontent.com/7028613/182032101-e62f3157-217c-4e1d-a312-3a583481197f.mov
The reason is new Xcode 13, but I can't install the previous, because macOS Monterey can't work with Xcode earlier, than Xcode 13.
The project needs an issue with adaptation to Xcode 13 – I can create it. As well, It could be useful to decide on supported iOS versions. The current minimum iOS version is 9.
If it's decided to support all older variants, this point can be described in the Readme, as this may raise a question in any issue. In another case, the minimum iOS version could be raised, as this can simplify further development.