Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Typo in seprator #40

Closed
1 task done
gmartenscb opened this issue Aug 28, 2023 · 2 comments · Fixed by #43
Closed
1 task done

[Bug]: Typo in seprator #40

gmartenscb opened this issue Aug 28, 2023 · 2 comments · Fixed by #43

Comments

@gmartenscb
Copy link

Contact Details (optional)

No response

What happened? Describe the bug

The configuration currently accepts a seprator option.
The correct spelling for this would be separator.

To Reproduce

No response

Expected behavior

window.$docsify.customPageTitle.separator to be recognised

Your OS

iOS

What browsers are you seeing the problem on? (optional)

No response

App Version (optional)

No response

Relevant log output (optional)

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@AlexCPU
Copy link

AlexCPU commented Sep 11, 2023

Eeek, this has been 'fixed' as a breaking change on a minor revision.

People using the suggested CDN snippet, which calls up version 1.x:

<script src="//cdn.jsdelivr.net/npm/@sujaykumarh/docsify-plugin-title@1.x/dist/plugin.min.js"></script>

Will have suddenly discovered that this functionality stopped working on their site, and had to come here to find out why. This should have been a major version number change, or have continued supporting the incorrect spelling such that it didn't break existing deployments.

@sujaykumarh
Copy link
Owner

sujaykumarh commented Sep 11, 2023

Fixed with v2.0.0, thanks for bringing it up @AlexCPU. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants