Fixes for gettext make process and postgresql database backup method #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 25, 2011 01:26
Previously, while 'make -C po' was changing the ./po/ source tree, 'make -C po clean' did not restore it, thus leaving the source tree changed after the build. This incurred burden (and inellegance) to the build process of downstream distribution packagers. This commit fixes the issue.
The commit ensures that .pgpass has the proper permissions before any passwords are written inside. It also restores the backup only if it was actually used.
database clusters using unix sockets.
breaking backup-manager on a broken postgresql installation.
database backup methods.
|
Thanks! Can you do it for the devel branch? It's the one which is preferred for a later release. |
|
Στις 25-12-2011, ημέρα Κυρ, και ώρα 04:01 -0800, ο/η Philippe Villiers
|
kissifrot
added a commit
that referenced
this pull request
Dec 26, 2011
Fixes for gettext make process and postgresql database backup method
kissifrot
added a commit
that referenced
this pull request
Dec 26, 2011
Devel: Commits of pull request #16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gettext make fix ensures that 'make clean' returns the po/ subtree to its original status, something that will make the life of downstream packagers a lot easier (cf. the Debian case: http://anonscm.debian.org/gitweb/?p=collab-maint/backup-manager.git;a=blobdiff;f=debian/rules;h=0b8ffbafe6a96429648087f043db8ba707e0f6a1;hp=cbf3a530172f942f8389955fcb96585a65c82d23;hb=0f78250a538571df8a744993b9c6e7ec94ac8d85;hpb=f0c4f52c825e096dd4f833187376f403dc6ca5a5)
The pgsql backup method fixes solve a security issue (previous code did not check the permissions of .pgpass, in the case that already existed, before writing there the passwords) and enhance the robustness and features of the pgsql backup method in a couple of other areas. The last one is just a change on naming conventions, but it makes sense, especially if other database backends are going to be supported in the future.
Code has been tested on top of the 0.7.10.1 release, plus the patches for the next Debian version of the package (cf. http://anonscm.debian.org/gitweb/?p=collab-maint/backup-manager.git;a=log;h=refs/heads/build). For the pgsql method, I have broken the original debian patch to four subpatches with equivalent results, in order to ease the review.