Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring to remove unneeded abstractions and methods. #58

Merged
merged 7 commits into from Mar 9, 2018
Merged

Refactoring to remove unneeded abstractions and methods. #58

merged 7 commits into from Mar 9, 2018

Conversation

cbeer
Copy link
Contributor

@cbeer cbeer commented Mar 9, 2018

No description provided.

@coveralls
Copy link

coveralls commented Mar 9, 2018 •
edited

Coverage Status

Coverage increased (+5.9%) to 70.482% when pulling 1629723 on refactoring into 747c529 on master.

mejackreed
mejackreed approved these changes Mar 9, 2018
View reviewed changes
Copy link
Contributor

@mejackreed mejackreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Reviewed this today AM. I like the removal of the unnecessary methods

@mejackreed mejackreed merged commit ba6657c into master Mar 9, 2018
@mejackreed mejackreed deleted the refactoring branch March 9, 2018 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejackreed mejackreed mejackreed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cbeer @coveralls @mejackreed