Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure for deploy #42

Merged
merged 4 commits into from
Feb 22, 2017
Merged

Configure for deploy #42

merged 4 commits into from
Feb 22, 2017

Conversation

mejackreed
Copy link
Contributor

@mejackreed mejackreed commented Feb 21, 2017 •
edited
Loading

Closes #38, Closes #23

Deploy to stage/prod successful

@jkeck
Copy link
Contributor

jkeck commented Feb 21, 2017 •
edited
Loading

I "fix" the test problem you're having here in #41. The rails/rspec upgrade will be a bit more significant and will take a bit more time. I'm thinking we should tease the rails/rspec upgrade out as separate work and ship #41 and rebase this on-top of that.

We can chat about that @ standup shortly.

@mejackreed mejackreed force-pushed the add-deploy branch 3 times, most recently from cd285af to 7927059 Compare February 21, 2017 21:21
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.788% when pulling c285193 on add-deploy into 0f2fee0 on master.

@mejackreed mejackreed changed the title [WIP] Configure for deploy Configure for deploy Feb 21, 2017
@jkeck jkeck merged commit 76c4b0e into master Feb 22, 2017
@jkeck jkeck deleted the add-deploy branch February 22, 2017 01:07
@jkeck jkeck removed the in progress label Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkeck jkeck jkeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mejackreed @jkeck @coveralls