Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use mirador gem #47

Merged
merged 2 commits into from
Feb 28, 2017
Merged

Use mirador gem #47

merged 2 commits into from
Feb 28, 2017

Conversation

mejackreed
Copy link
Contributor

Closes #46

@mejackreed
Copy link
Contributor Author

mejackreed commented Feb 27, 2017 •
edited
Loading

Question for @blalbrit .. are SUL/bnf/e-codices etc logos used in Colligo? I couldn't find them being used, but just double checking

Answered my own question. Was removed between v2.0.0 and v2.1.0 ProjectMirador/mirador@v2.0.0...v2.1.0#diff-c4af3073e5123eb521e9d080ff0c0e07

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.788% when pulling 5ff4463 on use-mirador-gem into c288b73 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.788% when pulling 5931c12 on use-mirador-gem into c288b73 on master.

jkeck
jkeck approved these changes Feb 28, 2017
View reviewed changes
Copy link
Contributor

@jkeck jkeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jkeck jkeck merged commit 8f075b6 into master Feb 28, 2017
@jkeck jkeck deleted the use-mirador-gem branch February 28, 2017 18:09
@jkeck jkeck removed the in progress label Feb 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkeck jkeck jkeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mejackreed @coveralls @jkeck