update dependencies and fix test suite. #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this there were indexing errors
mejackreed
force-pushed
the
update-dep
branch
from
f060ab4
to
81160d9
Compare
mejackreed
force-pushed
the
update-dep
branch
from
12066d4
to
1218269
Compare
atz
approved these changes
Feb 5, 2018
This was referenced Feb 6, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of changes here unfortunately to get things working. The biggest reason we needed to move to chrome driver was to be able to explicitly set the language to
en(rather than the default ofen-US). Mirador requests translations toenand will first 404 toen-UScausing some tests to fail. I wasn't able to accomplish this in Poltergeist, thus the move to headless chrome.