Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds annotot for storing annotations #69

Merged
merged 9 commits into from
Mar 1, 2018
Merged

Adds annotot for storing annotations #69

merged 9 commits into from
Mar 1, 2018

Conversation

mejackreed
Copy link
Contributor

@mejackreed mejackreed commented Feb 28, 2018 •
edited
Loading

A few things left to be resolved:

  • how do we want to disable this locally here? @cbeer mentioned using IP based restrictions? Or we could just not enable CORS which could effectively disable annotations not created from the same domain
  • how do we want communicate CORS support to the Vatican team? we are just shipping rack-cors

cc @eefahy

@coveralls
Copy link

coveralls commented Feb 28, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-32.1%) to 63.674% when pulling 9bd8004 on tots into 4a7e94b on master.

@eefahy eefahy merged commit 6793ea7 into master Mar 1, 2018
@eefahy eefahy deleted the tots branch March 1, 2018 01:32
This was referenced Mar 1, 2018
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mejackreed @coveralls @eefahy