rubocop Style/Next

sul-dlss-deprecated · Jan 7, 2016 · 1fd51cf · 1fd51cf
1 parent d16ac03
commit 1fd51cf
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -175,13 +175,6 @@ Style/NestedTernaryOperator:
   Exclude:
     - 'lib/fetcher.rb'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
-Style/Next:
-  Exclude:
-    - 'lib/indexer.rb'
-
 # Offense count: 3
 # Cop supports --auto-correct.
 Style/NumericLiterals:

diff --git a/lib/indexer.rb b/lib/indexer.rb
@@ -96,11 +96,10 @@ def index_druid_tree_branch(branch)
     object_paths.each do |o_path|
       object = solrize_object(o_path)
       objects << object if object != {} # Only add it if we have a valid object, the function ret
-      if objects.size == @@indexer_config['items_commit_every']
-        add_and_commit_to_solr(objects)
-        all_objects += objects
-        objects = []
-      end
+      next unless objects.size == @@indexer_config['items_commit_every']
+      add_and_commit_to_solr(objects)
+      all_objects += objects
+      objects = []
     end
 
     add_and_commit_to_solr(objects) if objects.size != 0