-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only convert index_map.json
files to .geojson
#848
Comments
@thatbudakguy advised converting all |
To my knowledge, the only reason we ever ingest JSON through our GIS pipeline is as geospatial data – that is, as geoJSON. The table above seems to bear that out. I think it's safe to rename all JSON to have the .geojson extension. The alternatives are:
|
It appears that PURL only displays For example: While we don't have any right now, JSON is a popular data format, and I could imagine non-GeoJSON files being accessioned in the future as part of a GIS dataset. Would we really want to assume that those are GeoJSON, and rewrite the filenames? Absent a way of reliably identifying GeoJSON files, I do like the idea of accessioneers naming known GeoJSON files with the PS. I created sul-dlss/sul-embed#2118 to track the fact that sul-embed needs to be updated to display the GeoJSON with the new extension. |
But as you say @thatbudakguy if we never imagine adding GIS items with other types of supporting JSON in them, then this can be closed. |
We are currently converting any
.json
file to use the.geojson
file extension. While reviewing the filenames used in GIS items I noticed that apart from one typo the only JSON filename that is used isindex_map.json
. In order to allow other types of JSON files to be present in GIS items we should only assume thatindex_map.json
is a GeoJSON file.The text was updated successfully, but these errors were encountered: