Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pom.xml - remove compiler plugin at top level #92

Merged
merged 1 commit into from
Feb 13, 2017

Conversation

dazza-codes
Copy link
Contributor

@dazza-codes dazza-codes commented Feb 11, 2017

The parent project has no code to compile, so removing the compiler plugin at this level. The compiler plugin is defined in the converter module, where it belongs.

This commit is a prelude to using a branch that will compile for java 7, because the code is java 7 compatible and it can compile on java 7 (this can be verified using the java-7 branch). To enable this option to build for java-7, the compiler config in the converter module needs to be modified. When it is modified, there are conflicts with the parent compiler plugin. As it turns out, we don't need the parent compiler plugin at all, so let's remove it.

(Note, this is not a proposal or recommendation to use java 7. This PR is only removing an extraneous/duplicate compiler plugin from the parent pom.xml file.)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 46.154% when pulling a088852 on no-compiler-for-root-project into 46c5589 on master.

@jgreben jgreben merged commit 5bae699 into master Feb 13, 2017
@jgreben jgreben deleted the no-compiler-for-root-project branch February 13, 2017 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants