Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: tests for error and info collection in DiscoveryReport#process_dobj #297

Closed
jmartin-sul opened this issue Sep 17, 2018 · 2 comments
Closed

MAINT: tests for error and info collection in DiscoveryReport#process_dobj #297

jmartin-sul opened this issue Sep 17, 2018 · 2 comments

Comments

@jmartin-sul
Copy link
Member

No description provided.

@jmartin-sul jmartin-sul mentioned this issue Sep 17, 2018
Closed
27 tasks
@atz
Copy link
Contributor

atz commented Sep 18, 2018

Could involve some refactoring of functionality to make smaller more testable methods, e.g.:

  • separate method to produce error flags from the base/counts hash.
  • separate method(s) for the smpl data/errors to be merged in

Or could just start testing the conditional bits already present.

@jmartin-sul jmartin-sul mentioned this issue Sep 21, 2018
Closed
30 tasks
@jmartin-sul jmartin-sul mentioned this issue Oct 1, 2018
Closed
24 tasks
@aaron-collier aaron-collier changed the title tests for error and info collection in DiscoveryReport#process_dobj MAINT: tests for error and info collection in DiscoveryReport#process_dobj May 9, 2019
@ndushay
Copy link
Contributor

ndushay commented Mar 17, 2022

closing this as our code coverage data can inform us of missing coverage.

@ndushay ndushay closed this as completed Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ndushay @atz @jmartin-sul