Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCC: remove rails pieces we won't use #30

Closed
9 of 12 tasks
ndushay opened this issue Aug 24, 2017 · 2 comments
Closed
9 of 12 tasks

PCC: remove rails pieces we won't use #30

ndushay opened this issue Aug 24, 2017 · 2 comments
Assignees

Comments

@ndushay
Copy link
Contributor

ndushay commented Aug 24, 2017

(we can always add them back later if we need them; rails new created a lot of stuff we won't use)

  • app/assets folder

  • app/channels folder

  • app/views folder

  • config/cable.yml
    - [ ] config/spring.rb we 'need' this for development environment

  • config/initializers/assets.rb (? - might also require tweaks to application.rb to not use the rails piece, and then to config/environments/xxx.rb to not use the settings ...)

  • lib/assets folder

  • lib/tasks folder

  • spec/helpers folder

  • spec/views folder

less certain

  • app/helpers
  • app/jobs
  • app/mailers
@ndushay
Copy link
Contributor Author

ndushay commented Aug 25, 2017

Should we consider pairing down our require "rails/all" to just the pieces we need, too? (config/application.rb) It could make our tests run faster if it is loading less code ... See http://guides.rubyonrails.org/initialization.html#loading-rails

@tallenaz
Copy link
Collaborator

I'm open to that. From a first pass, the app will start up with, at minimum:

require 'active_record/railtie'
require 'action_controller/railtie'
require 'action_mailer/railtie'

It's unhappy without action_mailer/railtie, even though we probably won't use mailers. Anyway, it's a smaller list than what rails/all encompasses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants