Skip to content

Commit

Permalink
a bit more comment and spec description cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
jmartin-sul committed Oct 31, 2017
1 parent 446b8e9 commit 33b3686
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
1 change: 0 additions & 1 deletion app/services/preserved_object_handler.rb
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@ def update_version
update_preserved_object(pres_object, incoming_version, incoming_size)
update_db_object(pres_object, results)
end
# TODO: comparable else for the pres object version mismatch
else
results << result_hash(UNEXPECTED_VERSION, 'PreservationCopy')
results << version_comparison_results(pres_copy)
Expand Down
8 changes: 4 additions & 4 deletions spec/services/preserved_object_handler_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -354,25 +354,25 @@
context 'incoming version newer than PreservationCopy but not PreservedObject' do
context 'PreservedObject version same' do
it 'does something' do
skip('write this spec')
skip('write this spec; we need to figure out the desired behavior.')
end
end
context 'PreservedObject version greater' do
it 'does something' do
skip('write this spec')
skip('write this spec; we need to figure out the desired behavior.')
end
end
end

context 'incoming version newer than PreservedObject but not PreservationCopy' do
context 'PreservationCopy version same' do
it 'does something' do
skip('write this spec')
skip('write this spec; we need to figure out the desired behavior.')
end
end
context 'PreservationCopy version greater' do
it 'does something' do
skip('write this spec')
skip('write this spec; we need to figure out the desired behavior.')
end
end
end
Expand Down

0 comments on commit 33b3686

Please sign in to comment.