Update to use moab-versioning 2.0 #3
Conversation
| s.add_dependency 'rest-client', '~> 1.6' | ||
| s.add_dependency 'moab-versioning', '~> 1.3' | ||
| s.add_dependency 'moab-versioning', '~> 2.0' |
There was a problem hiding this comment.
I don't know anything about 2.0, the last release that I'm aware of is 1.4 (I think). So I can't evaluate this without dedicated time to evaluate the 2.0 release.
|
Looks good to go. Having reviewed the moab 2.x, I'm OK with an upgrade given all the specs are passing. |
|
Something is funky on travis for the ruby 2.1.2 build, everything else is OK. It can't install this gem at 0.6.0. The ruby 2.3.0 works, so that's good to know. |
|
Ah, yep. I think we've found this build error on other projects on travis.. something about bundler versions, maybe? I'd suggest dropping the 2.1.2 build, 👌 ? |
|
If we drop the 2.1.2 build, should we also upgrade the ruby version on all the sdr-* boxes? It looks like this repo runs OK on 2.2.4, so I wonder if all the SDR-PC components and robot stuff all works on 2.2.4? Or are we feeling lucky today (just drop it for travis and assume it's OK on our boxes)? |
|
I've applied the fix for older ruby builds, and the build is now passing under ruby 2.1.2. |
Update to use moab-versioning 2.0
No description provided.