This repository has been archived by the owner on Jan 11, 2020. It is now read-only.
deprecate manifest; use preservation-client manifest or signature_catalog #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why was this change made?
In order to get rid of this Sinatra app! This is the very last API call that wasn't yet deprecated.
To be certain we didn't miss any spots as we move the
manifestAPI endpoint from here to preservation catalog.Was the documentation (README, API, wiki, consul, etc.) updated?
yes, in the form of deprecation messages and Honeybadger notifications.
When can we decommission this app?
After this is deployed (Monday deploy is soon enough), we watch for any Honeybadger alerts; if none, we can decommission sdr-services-app!