-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow site admins to manage other site admins #1404
Conversation
@@ -75,5 +75,5 @@ | |||
|
|||
|
|||
Spotlight.onLoad(function() { | |||
$('.edit_exhibit').spotlight_users(); | |||
$('.edit_exhibit, .admin-users').spotlight_users(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Identifier 'spotlight_users' is not in camel case.
There is a bit of a spacing issue in the form where the label has If anybody has any ideas as to why this is happening or proposed solutions, I'm all ears. |
Odd about the reduced coverage. I think it's caused by relevant lines of code being moved, but that code is tested elsewhere (and showing 100% coverage). It seems strange to me that this would cause a drop of 0.2%. |
Agreed about the coverage; the coveralls report is less than helpful. Should we wait to merge this until we can look at the label spacing problem? |
Yeah, maybe I can show you what is going on. It's pretty minor so we can fix it up and later today or tomorrow. |
👌 |
87773a7
to
d8a52e7
Compare
d8a52e7
to
9d4288f
Compare
👍 |
Ah! Makes perfect sense. Thanks @cbeer! |
I'm not sure about perfect sense, but it probably helps keeping things aligned (and if we weren't using tables, we might need it..) |
Allow site admins to manage other site admins
Closes #849