This repository has been archived by the owner on Sep 24, 2019. It is now read-only.
Adding rake task to register crawl object from file #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalsum
force-pushed
the
registering-script
branch
4 times, most recently
from
b3dcdb2
to
745d9ea
Compare
|
@tingulfsen here you go :) |
aalsum
force-pushed
the
registering-script
branch
4 times, most recently
from
8058611
to
adc2b17
Compare
| fail_count = 0 | ||
| registrar = Was::Registrar::RegisterCrawlObject.new | ||
|
|
||
| input_file = File.open(input_file_path) |
There was a problem hiding this comment.
Consider closing the file within self.register: http://stackoverflow.com/questions/4795447/rubys-file-open-and-the-need-for-f-close
aalsum
force-pushed
the
registering-script
branch
from
adc2b17
to
3ef6cec
Compare
| end | ||
| puts "\nRegistering crawl objects:\nSuccess: #{success_count}\nFail: #{fail_count}" | ||
| input_file.close | ||
| end |
There was a problem hiding this comment.
@tingulfsen I updated the code with the closing statement.
tingulfsen
added a commit
that referenced
this pull request
Aug 25, 2015
Adding rake task to register crawl object from file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.